Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751167Ab0HUAy7 (ORCPT ); Fri, 20 Aug 2010 20:54:59 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48731 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843Ab0HUAy5 convert rfc822-to-8bit (ORCPT ); Fri, 20 Aug 2010 20:54:57 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Linus Torvalds Date: Fri, 20 Aug 2010 17:54:07 -0700 Message-ID: Subject: Re: [RFC] mlock/stack guard interaction fixup To: Mike Snitzer Cc: Ian Campbell , linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Greg KH , Peter Zijlstra Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 789 Lines: 19 On Fri, Aug 20, 2010 at 5:20 PM, Mike Snitzer wrote: > > In 0002-mm-make-the-mlock-stack-guard-page-checks-stricter.patch you > switch __mlock_vma_pages_range from 'start += PAGE_SIZE' to 'addr += > PAGE_SIZE'. > > So would that be a bugfix for commit d7824370? ?Seems likely given > start isn't used after that point. Yup, that's a bug-fix. Although the real bug was having two variables (addr and start) both be the same thing. Probably for some random historical reason. And I didn't fix that. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/