Date: Sat, 21 Aug 2010 05:11:42 -0400 (EDT)
From: Miloslav Trmac <mitr@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>, linux-crypto@vger.kernel.org,
        Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>,
        Neil Horman <nhorman@redhat.com>, linux-kernel@vger.kernel.org
Message-ID: <88057790.1047131282381902365.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
In-Reply-To: <4C6E79B2.1040309@s5r6.in-berlin.de>
Subject: Re: [PATCH 01/19] User-space API definition
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 25

----- "Stefan Richter" <stefanr@s5r6.in-berlin.de> wrote:
> Miloslav Trmač wrote:
> > --- /dev/null
> > +++ b/include/linux/ncr.h
> [...]
> > +struct ncr_session_input_data {
> > +	const void __user *data;
> > +	__kernel_size_t data_size;
> > +};
> 
> Why not using fixed-size fit-all members?
> 
> struct ncr_session_input_data {
> 	__u64 data;		/* user pointer, cast to/from u64 */
> 	__u32 data_size;	/* or __u64? */
> };
> 
> And then get rid of all the COMAPT code paths.
That would make the interface less natural, and any architecture that wanted to have larger pointers (I understand IBM did this back the '80s, so it can happen again) would result in a significantly worse mess than the widely used compat_ioctl mechanism.
    Mirek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/