Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839Ab0HUKFu (ORCPT ); Sat, 21 Aug 2010 06:05:50 -0400 Received: from smtp.nokia.com ([192.100.122.233]:35962 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751Ab0HUKFr (ORCPT ); Sat, 21 Aug 2010 06:05:47 -0400 Subject: Re: [PATCH 0/6] improve list_sort test From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Don Mullis Cc: linux-kernel@vger.kernel.org, David Airlie , Dave Chinner In-Reply-To: References: <1281168645-18413-1-git-send-email-dedekind1@gmail.com> <1281261789.2384.11.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Sat, 21 Aug 2010 13:03:53 +0300 Message-ID: <1282385033.2358.38.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 (2.30.2-4.fc13) Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 21 Aug 2010 10:05:31.0828 (UTC) FILETIME=[63B8FF40:01CB4118] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 25 On Sun, 2010-08-08 at 13:07 -0700, Don Mullis wrote: > On Sun, Aug 8, 2010 at 12:31 PM, Don Mullis wrote: > > Artem Bityutskiy writes: > >> Actually, your 'list_sort()' version does have a problem. I found out > >> that it calls 'cmp(priv, a, b)' with 'a = b' sometimes, and in these > >> cases 'a' and 'b' can point to something which is not a valid element of > >> the original list. Probably a senitel or something like that. > > Looks like if the original list is a POT in length, the first callback > from line 73 will pass a==b both pointing to the original list_head. > Would you be able to test this fix? I'll turn your patch into a git am-able form and add CC to stable, and send to you. You can then propagate it forward, or if you want, I can send it to Andrew. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/