DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=a3vxVuo5riau5jaJm6QUHiV0M8SEC1YgoY2LNhpAo8Zd655+J+i3y/7T0wdM+fy0+OIcX2P1LF7MZBejKY5QjHBS1yaafYp7MPyF8whQefP2voz006Lc69bsIwWH+5wdj3VElV7wC0PPJeLYwivOwJCptfN7sAIhGpG8JaSCr70=;
Message-ID: <292036.65081.qm@web37607.mail.mud.yahoo.com>
Date: Sat, 21 Aug 2010 06:50:12 -0700 (PDT)
From: Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH] My work on MemoryStick system
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
In-Reply-To: <1282352917.13597.5.camel@maxim-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1212
Lines: 42

> 
> I just tested this series with Jmicron, and unfortunelly
> there are bugs.
> 
> * driver refuses to handle 26 byte TPC I use to read regs
> (sizeof(ms_registers). If I bump it to 32, it works.

It will work with any multiply of 4 (24 and 28 work as well). It's a known
"feature".

> 
> * With this fix first few reads still fail.
> That means that card isn't detected always because boot
> blocks might not
> be read.
> Later card works fine.
> 
> * Also I found out that msproblk.c allocates memory for
> attributes IO
> using stock kmalloc, and hangs that to driver.
> However if driver doesn't support such address, it will
> fail.

Why would hardware do anything at all with attribute memory space?

> I fixed that in my driver by properly calling dma_unmap_sg,
> and thus
> using SWIOTLB if necessary.
> But Jmicron driver doesn't unmap its sg.
> (Yet the system with Jmicron device has just one GB, so
> this isn't the
> problem I am seeing).
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/