From: Ian Campbell <ijc@hellion.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org,
        akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
        Greg KH <gregkh@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Jeremy Fitzhardinge <jeremy@goop.org>
In-Reply-To: <1282460275.11348.865.camel@localhost.localdomain>
References: <AANLkTimuP9cFvd4pfqy6=vixSMdagrSEv1-VLNAEuWgr@mail.gmail.com>
	 <1282391770.29609.1223.camel@localhost.localdomain>
	 <AANLkTimYnfewBCDNYXZHxbcX=TRE__Cu07_FFK_kAK2h@mail.gmail.com>
	 <1282460275.11348.865.camel@localhost.localdomain>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-KuyM1442DnPTbvU7MFge"
Date: Sun, 22 Aug 2010 08:33:06 +0100
Message-ID: <1282462386.11348.871.camel@localhost.localdomain>
Mime-Version: 1.0
Subject: Re: [RFC] mlock/stack guard interaction fixup
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2127
Lines: 62


--=-KuyM1442DnPTbvU7MFge
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable

On Sun, 2010-08-22 at 07:57 +0100, Ian Campbell wrote:
> On Sat, 2010-08-21 at 08:48 -0700, Linus Torvalds wrote:
> > On Sat, Aug 21, 2010 at 4:56 AM, Ian Campbell <ijc@hellion.org.uk> wrot=
e:
> > >
> > > I don't know that they are particularly good tests for this change bu=
t I
> > > also ran allmodconfig kernel build and ltp on 2.6.35.3+fixes without
> > > issue. Are there any good mlock heavy workloads?
> >=20
> > mlock itself isn't very interesting, I think more interesting is
> > testing that the doubly linked list handles all the cases correctly.
> > Something that splits mappings, unmaps partial ones etc etc. Running
> > something like Electric Fence is probably a good idea.
>=20
> EF_DISABLE_BANNER=3D1 EF_ALLOW_MALLOC_0=3D1 LD_PRELOAD=3Dlibefence.so.0.0=
 make
>=20
> craps out pretty quickly with:
>=20
>           CC      init/main.o
>        =20
>         ElectricFence Exiting: mprotect() failed: Cannot allocate memory
>         make[1]: *** [init/main.o] Error 255
>         make: *** [init] Error 2
>=20
> but it does that with 2.6.35.3, 2.6.35.2, 2.6.35.1 and 2.6.35 too so it
> doesn't seem to be breakage relating to any of the stack guard stuff

I increased the vm.max_map_count sysctl and now things are rolling
along. Will let you know how I get on.

--=20
Ian Campbell

Arithmetic:
	An obscure art no longer practiced in the world's developed countries.

--=-KuyM1442DnPTbvU7MFge
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEABECAAYFAkxw0rIACgkQM0+0qS9rzVnjnwCg5Y++SrwxhiRRkuPRbJuyGNNC
3nUAoI7+vaym4gJFO8E3d5XVPUPvgRCf
=5S8g
-----END PGP SIGNATURE-----

--=-KuyM1442DnPTbvU7MFge--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/