From: Ian Campbell <ijc@hellion.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org,
        akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
        Greg KH <gregkh@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Jeremy Fitzhardinge <jeremy@goop.org>
In-Reply-To: <1282462386.11348.871.camel@localhost.localdomain>
References: <AANLkTimuP9cFvd4pfqy6=vixSMdagrSEv1-VLNAEuWgr@mail.gmail.com>
	 <1282391770.29609.1223.camel@localhost.localdomain>
	 <AANLkTimYnfewBCDNYXZHxbcX=TRE__Cu07_FFK_kAK2h@mail.gmail.com>
	 <1282460275.11348.865.camel@localhost.localdomain>
	 <1282462386.11348.871.camel@localhost.localdomain>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-tDgZIHsCRsJQ1VJj5MYC"
Date: Sun, 22 Aug 2010 10:55:17 +0100
Message-ID: <1282470917.11348.891.camel@localhost.localdomain>
Mime-Version: 1.0
Subject: Re: [RFC] mlock/stack guard interaction fixup
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3291
Lines: 91


--=-tDgZIHsCRsJQ1VJj5MYC
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable

On Sun, 2010-08-22 at 08:33 +0100, Ian Campbell wrote:
> On Sun, 2010-08-22 at 07:57 +0100, Ian Campbell wrote:
> > On Sat, 2010-08-21 at 08:48 -0700, Linus Torvalds wrote:
> > > On Sat, Aug 21, 2010 at 4:56 AM, Ian Campbell <ijc@hellion.org.uk> wr=
ote:
> > > >
> > > > I don't know that they are particularly good tests for this change =
but I
> > > > also ran allmodconfig kernel build and ltp on 2.6.35.3+fixes withou=
t
> > > > issue. Are there any good mlock heavy workloads?
> > >=20
> > > mlock itself isn't very interesting, I think more interesting is
> > > testing that the doubly linked list handles all the cases correctly.
> > > Something that splits mappings, unmaps partial ones etc etc. Running
> > > something like Electric Fence is probably a good idea.
> >=20
> > EF_DISABLE_BANNER=3D1 EF_ALLOW_MALLOC_0=3D1 LD_PRELOAD=3Dlibefence.so.0=
.0 make
> >=20
> > craps out pretty quickly with:
> >=20
> >           CC      init/main.o
> >        =20
> >         ElectricFence Exiting: mprotect() failed: Cannot allocate memor=
y
> >         make[1]: *** [init/main.o] Error 255
> >         make: *** [init] Error 2
> >=20
> > but it does that with 2.6.35.3, 2.6.35.2, 2.6.35.1 and 2.6.35 too so it
> > doesn't seem to be breakage relating to any of the stack guard stuff
>=20
> I increased the vm.max_map_count sysctl and now things are rolling
> along. Will let you know how I get on.

So its slow and memory intensive as hell due to efence so my test box is
struggling[0] but it has compiled 270+ .o files successfully so I think
it's OK from that perspective. I think it'll be quite a while before I
can say its passed an allmodconfig under efence though.

In the meantime I notice you've committed the patches. Can we get them
queued up for stable backports at some point? I appreciate you might
want them to bake for a bit longer in 2.6.36-rc first.

Greg, we are talking about:
0e8e50e20c837eeec8323bba7dcd25fe5479194c mm: make stack guard page logic us=
e vm_prev pointer
7798330ac8114c731cfab83e634c6ecedaa233d7 mm: make the mlock() stack guard p=
age checks stricter
297c5eee372478fc32fec5fe8eed711eedb13f3d mm: make the vma list be doubly li=
nked

Cheers,
Ian.

[0] It's a 4G x 4 core box which normally does -j16 builds with no swap.
Now a -j4 will send it deep into the 16G of swap I added this morning,
and even a -j3 is a bit tight. I knew efence was resource intensive but
this still surprised me.

--=20
Ian Campbell

Who does not love wine, women, and song,
Remains a fool his whole life long.
		-- Johann Heinrich Voss

--=-tDgZIHsCRsJQ1VJj5MYC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEABECAAYFAkxw9AUACgkQM0+0qS9rzVkYmQCdGVqT1Lm42Vk6YcGgljR7Hyp5
b4IAoNyg2ocKo9AH1/YmpJHUOcu2EC5E
=lUdW
-----END PGP SIGNATURE-----

--=-tDgZIHsCRsJQ1VJj5MYC--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/