Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753294Ab0HWGal (ORCPT ); Mon, 23 Aug 2010 02:30:41 -0400 Received: from smtp.nokia.com ([192.100.122.233]:36548 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327Ab0HWGai (ORCPT ); Mon, 23 Aug 2010 02:30:38 -0400 Date: Mon, 23 Aug 2010 09:29:57 +0300 From: Felipe Balbi To: "ext Hiremath, Vaibhav" Cc: "Balbi Felipe (Nokia-MS/Helsinki)" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "byron.bbradley@gmail.com" , "linux-omap@vger.kernel.org" Subject: Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support Message-ID: <20100823062957.GA1068@nokia.com> Reply-To: felipe.balbi@nokia.com References: <1282393829-7326-2-git-send-email-hvaibhav@ti.com> <20100821140541.GA31697@nokia.com> <19F8576C6E063C45BE387C64729E7394044F1252C6@dbde02.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <19F8576C6E063C45BE387C64729E7394044F1252C6@dbde02.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginalArrivalTime: 23 Aug 2010 06:30:25.0022 (UTC) FILETIME=[AB7E31E0:01CB428C] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 804 Lines: 24 Hi, please break your lines at 80-characters. Also the [Hiremath, Vaibhav] is unnecessary. On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote: >> don't you need some locking on the irq handler ? a mutex maybe ? Just >> wondering... >> >[Hiremath, Vaibhav] Yes definitely we do need locking here, I thought >of adding locking mechanism in subsequent patch, does it makes sense? so you add a buggy patch and fix it later ? If you already know it's buggy, why not changing the patch that adds the bug ? -- balbi DefectiveByDesign.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/