DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        b=p8e6UNImLtrE9lYsM0R14sD9qbD8DG7yh397Vbp7971XRLb0nXW/H73ex/fdNqRmTD
         g1oWByj+hTMbG7cjbs4grpoqfnU+k0Yh25Zq27wToBcFV7ZLYuIODGS13UXHIukWpwEA
         5eUeSD2nC3S59c4rWyp7kJZ4RGIr7vELT1FhQ=
MIME-Version: 1.0
In-Reply-To: <AANLkTinuFrE0ZpTpgaEQr5GYFXzGjHYq7FC-sY-UiVFi@mail.gmail.com>
References: <20100818083346.GA6308@july>
	<AANLkTinuFrE0ZpTpgaEQr5GYFXzGjHYq7FC-sY-UiVFi@mail.gmail.com>
Date: Mon, 23 Aug 2010 15:53:49 +0900
Message-ID: <AANLkTimyC2PcTgEbeKNQTCobxEKj-+wMViEOhNfE6JTg@mail.gmail.com>
Subject: Re: [PATCH] Ramoops: use the platform data structure instead of
 module params
From: Kyungmin Park <kmpark@infradead.org>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1111
Lines: 36

On Mon, Aug 23, 2010 at 3:48 PM, Marco Stornelli
<marco.stornelli@gmail.com> wrote:
> 2010/8/18 Kyungmin Park <kmpark@infradead.org>:
>> From: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> As each board and system has different memory for ramoops. It's better to define the platform data instead of module params.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>
> It seems good. Currently there isn't any code that register a ramoops
> device, isn't it?

At this time

I wrote it below

static struct ramoops_platform_data goni_ramoops_data = {
        .mem_size               = SZ_16K,
        .mem_address            = 0xED000000,   /* MODEM SRAM */
};

static struct platform_device goni_ramoops = {
        .name = "ramoops",
        .dev = {
                .platform_data = &goni_ramoops_data,
        },
};

Thank you,
Kyungmin Park
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/