Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753838Ab0HWKCy (ORCPT ); Mon, 23 Aug 2010 06:02:54 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:34738 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752141Ab0HWKCv (ORCPT ); Mon, 23 Aug 2010 06:02:51 -0400 Date: Mon, 23 Aug 2010 11:02:48 +0100 From: Mark Brown To: Axel Lin Cc: linux-kernel , Liam Girdwood , Mike Rapoport Subject: Re: [PATCH 2/2] regulator: tps6586x-regulator - fix bit_mask parameter for tps6586x_set_bits() Message-ID: <20100823100248.GG6061@rakim.wolfsonmicro.main> References: <1282487895.23014.19.camel@phoenix> <1282488162.23014.24.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1282488162.23014.24.camel@phoenix> X-Cookie: Advancement in position. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 15 On Sun, Aug 22, 2010 at 10:42:42PM +0800, Axel Lin wrote: > The third parameter of tps6586x_set_bits() is the bit_mask, > thus we should use (1 << ri->go_bit) instead of ri->go_bit. > > Signed-off-by: Axel Lin Acked-by: Mark Brown but I'd be much happier if someone who actually has the hardware could verify that this is OK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/