Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150Ab0HWMIc (ORCPT ); Mon, 23 Aug 2010 08:08:32 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:58514 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575Ab0HWMI3 (ORCPT ); Mon, 23 Aug 2010 08:08:29 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=Vdk+JwXdyjkp8E3s776H+EKMSagLDMV9lPQr3PP1iS/9ShyOdSpMXY5GXpOoHgTkuI czgeI0ZEavUd1rXB2BzhOE2Ml8Ve4V0CKOGChmWAQHTWQRsOr7YjhLXCwoRVMhw5CjFb s4OWKNcPXWId9qFUxLkcyYDKJ/0YHC3E80Tj0= Message-ID: <4C72639C.6090108@gmail.com> Date: Mon, 23 Aug 2010 14:03:40 +0200 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 MIME-Version: 1.0 To: Stephan Diestelhorst CC: "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-pm@lists.osdl.org" , Stephan Diestelhorst Subject: Re: [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM References: <201007091750.05020.stephan.diestelhorst@amd.com> <4C6B79C8.7080602@gmail.com> <201008191823.57915.stephan.diestelhorst@amd.com> In-Reply-To: <201008191823.57915.stephan.diestelhorst@amd.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 33 Hello, sorry about the delay. On 08/19/2010 06:23 PM, Stephan Diestelhorst wrote: > It says "max_performance", I have not touched anyhting. So it has been > like that all the time. Would this explain why your patch did not show > the debug printout? Hmm... okay. Yeah, if you haven't been using IPM at all, there won't be any debug messages but at the same time the posted patch should have had the same effect as Rafael's patch as IPM path isn't traveled at all. Can you please check the followings? * You're actually running the correct patched kernel and modules. It probably is a good idea to add a printk message. ie. Apply the patch and add a printk() in ata_host_request_pm() in libata-core.c and make sure the debug messages appears. * Rafael's patch actually fixes the problem. If you haven't been using IPM at all, Rafael's patch and mine should behave exactly the same (ie. no IPM operation at all during suspend/resume). It could be that you're seeing a different issue. Rafael, can you please test my patch and see how your case behaves? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/