DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=oXuI2wOqHki0TlCplBba7M7ywvmRcjwjZCaLEf3nhiGQRLd0+hh++IJGtDpDam/SNx
         ZQCmQLJMxvQ2flXoL1MJfHZguA5jIaKgzq0Ts5myeyKsNzUiwDdEruv+f/tkyCqn4w+I
         IC4E8cffoDEutO11fPfFzSMBP7NPv/2+PRbTk=
Subject: Re: [PATCH 2/3 RESEND] ptrace: cleanup address space conversion on
 ptrace_request()
From: Namhyung Kim <namhyung@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Roland McGrath <roland@redhat.com>,
        Oleg Nesterov <oleg@redhat.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20100823162105.GA19164@infradead.org>
References: <201008222206.18523.arnd@arndb.de>
	 <1282579575-9189-1-git-send-email-namhyung@gmail.com>
	 <20100823162105.GA19164@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 24 Aug 2010 01:38:09 +0900
Message-ID: <1282581489.1659.13.camel@leonhard>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 633
Lines: 25

2010-08-23 (Mon), 12:21 -0400, Christoph Hellwig:
> Just make this a
> 
> 	void __user *datap = (void __user *)data;
> 
> and you can pass it around withjout additional casts.  Also no need
> for the force here I think.
> 

But removing __force results in following sparse warning:

 ptrace.c:567:40: warning: cast adds address space to expression
(<asn:1>)


-- 
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/