Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168Ab0HWSAJ (ORCPT ); Mon, 23 Aug 2010 14:00:09 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:41069 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423Ab0HWSAE (ORCPT ); Mon, 23 Aug 2010 14:00:04 -0400 Message-ID: <4C72B6F7.8010706@kernel.org> Date: Mon, 23 Aug 2010 10:59:19 -0700 From: Yinghai Lu User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100714 SUSE/3.0.6 Thunderbird/3.0.6 MIME-Version: 1.0 To: "H. Peter Anvin" CC: Daniel Kiper , mingo@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86, apic: Fix apic=debug boot crash References: <20100819224616.GB9967@router-fw-old.local.net-space.pl> <20100823081212.GA13297@router-fw-old.local.net-space.pl> <9cca0990-1b78-40e7-a71d-f550b4f504aa@email.android.com> In-Reply-To: <9cca0990-1b78-40e7-a71d-f550b4f504aa@email.android.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 43 On 08/23/2010 07:54 AM, H. Peter Anvin wrote: > It's already applied. > > "Daniel Kiper" wrote: > >> Hi, >> >> On Fri, Aug 20, 2010 at 12:24:20PM -0700, Yinghai Lu wrote: >>> On Fri, Aug 20, 2010 at 5:41 AM, tip-bot for Daniel Kiper >>> wrote: >>>> Commit-ID: ?05e407603e527f9d808dd3866d3a17c2ce4dfcc5 >>>> Gitweb: ? ? http://git.kernel.org/tip/05e407603e527f9d808dd3866d3a17c2ce4dfcc5 >>>> Author: ? ? Daniel Kiper >>>> AuthorDate: Fri, 20 Aug 2010 00:46:16 +0200 >>>> Committer: ?Ingo Molnar >>>> CommitDate: Fri, 20 Aug 2010 10:18:28 +0200 >>>> >>>> x86, apic: Fix apic=debug boot crash >>>> >>>> Fix a boot crash when apic=debug is used and the APIC is >>>> not properly initialized. >>>> >>>> This issue appears during Xen Dom0 kernel boot but the >>>> fix is generic and the crash could occur on real hardware >>>> as well. >>> >>> Do you have any report on real hardware? >>> that could not happen on real hardware. >> >> Till now no, however I think it is good idea >> to apply this patch now. It is not worth to wait >> for another null pointer dereference. no, we should add BUG_ON() etc debug info there to see why that null cfg could happen. because according to code, we should have null there. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/