Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244Ab0HWTAS (ORCPT ); Mon, 23 Aug 2010 15:00:18 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:37765 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752708Ab0HWTAP (ORCPT ); Mon, 23 Aug 2010 15:00:15 -0400 From: "Rafael J. Wysocki" To: Tejun Heo Subject: Re: [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM Date: Mon, 23 Aug 2010 20:58:33 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.36-rc1-rjw+; KDE/4.4.4; x86_64; ; ) Cc: Stephan Diestelhorst , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-pm@lists.osdl.org" , Stephan Diestelhorst References: <201007091750.05020.stephan.diestelhorst@amd.com> <201008191823.57915.stephan.diestelhorst@amd.com> <4C72639C.6090108@gmail.com> In-Reply-To: <4C72639C.6090108@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008232058.33542.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 33 On Monday, August 23, 2010, Tejun Heo wrote: > Hello, sorry about the delay. > > On 08/19/2010 06:23 PM, Stephan Diestelhorst wrote: > > It says "max_performance", I have not touched anyhting. So it has been > > like that all the time. Would this explain why your patch did not show > > the debug printout? > > Hmm... okay. Yeah, if you haven't been using IPM at all, there won't > be any debug messages but at the same time the posted patch should > have had the same effect as Rafael's patch as IPM path isn't traveled > at all. Can you please check the followings? > > * You're actually running the correct patched kernel and modules. It > probably is a good idea to add a printk message. ie. Apply the > patch and add a printk() in ata_host_request_pm() in libata-core.c > and make sure the debug messages appears. > > * Rafael's patch actually fixes the problem. If you haven't been > using IPM at all, Rafael's patch and mine should behave exactly the > same (ie. no IPM operation at all during suspend/resume). It could > be that you're seeing a different issue. > > Rafael, can you please test my patch and see how your case behaves? This one: http://lkml.org/lkml/2010/8/5/328 ? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/