Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463Ab0HWTxG (ORCPT ); Mon, 23 Aug 2010 15:53:06 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:48300 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971Ab0HWTxE convert rfc822-to-8bit (ORCPT ); Mon, 23 Aug 2010 15:53:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=DVbH+6aQIm37lbIgEBmJACJ0xQ9H3s+U0NvXGcCLiQPRMKH6ROTat3uMvNgJdvy24P heE1maLTt1Zts+CcZigeVVwDGnDEUQJPTVmBdpfeorQnjWlFuaO5EJ1mASnD49xGWy+a NIcxjtLQaBnTKyNg+96kbUSSdv8qTSidjG8IU= MIME-Version: 1.0 In-Reply-To: <4C725B75.9000106@redhat.com> References: <20100820011054.GA11297@tpepper-t61p.dolavim.us> <4C724BDB.8020604@redhat.com> <4C724D13.6000807@redhat.com> <4C725B75.9000106@redhat.com> Date: Mon, 23 Aug 2010 12:53:00 -0700 X-Google-Sender-Auth: wKCf-A6uIqjFBgEb3P7BVNSFsOQ Message-ID: Subject: Re: [PATCH 0/4 v2] kvm: rework KVM mmu_shrink() code From: Tim Pepper To: Avi Kivity Cc: Xiaotian Feng , Marcelo Tosatti , Lai Jiangshan , Dave Hansen , LKML , kvm@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 45 On Mon, Aug 23, 2010 at 4:28 AM, Avi Kivity wrote: > ?On 08/23/2010 02:11 PM, Xiaotian Feng wrote: >> >> On Mon, Aug 23, 2010 at 6:27 PM, Avi Kivity ?wrote: >>> >>> ?On 08/23/2010 01:22 PM, Avi Kivity wrote: >>>> >>>> I see a lot of soft lockups with this patchset: >>> >>> This is running the emulator.flat test case, with shadow paging. ?This >>> test >>> triggers a lot (millions) of mmu mode switches. >>> >> Does following patch fix your issue? >> > > It does indeed! Thanks Xiaotian Feng! Avi: here's also a minor whitespace fixup on top of the previous. diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index f83b941..0c56484 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -1696,8 +1696,7 @@ void kvm_mmu_change_mmu_pages(struct kvm *kvm, unsigned in page = container_of(kvm->arch.active_mmu_pages.prev, struct kvm_mmu_page, link); - kvm_mmu_prepare_zap_page(kvm, page, - &invalid_list); + kvm_mmu_prepare_zap_page(kvm, page, &invalid_list); kvm_mmu_commit_zap_page(kvm, &invalid_list); } goal_nr_mmu_pages = kvm->arch.n_used_mmu_pages; Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/