Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636Ab0HWVVx (ORCPT ); Mon, 23 Aug 2010 17:21:53 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:44253 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754273Ab0HWVVv (ORCPT ); Mon, 23 Aug 2010 17:21:51 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=dqWUcE7o5ZSk/CywlE0KzTtAT7x2AhcCkftZD+xSCGgtQxTp84KZGOBgmlq5IR43X1 ozLMGdZVLfmFo+QKIGONbWwKNoJDyez7hXaH6zoiBWF4vBwsUR63uiDSZaTVdvRmAha5 t85coRAtnGxM12UzbADfGywxuK/CWzLp9c+IY= Date: Mon, 23 Aug 2010 23:21:03 +0200 From: Dan Carpenter To: Anton Vorontsov Cc: Daniel Mack , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] pda_power: remove unneeded assignment Message-ID: <20100823212103.GA7340@bicker> Mail-Followup-To: Dan Carpenter , Anton Vorontsov , Daniel Mack , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 24 We never use the "ret" value from this assignment, and also PTR_ERR(NULL) is zero. I looked at it and this driver is designed to accept a NULL value for "ac_draw". So there isn't a bug in the original code and we can just remove this confusing assignment. Signed-off-by: Dan Carpenter diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c index 69f8aa3..63a6a4d 100644 --- a/drivers/power/pda_power.c +++ b/drivers/power/pda_power.c @@ -279,7 +279,6 @@ static int pda_power_probe(struct platform_device *pdev) if (IS_ERR(ac_draw)) { dev_dbg(dev, "couldn't get ac_draw regulator\n"); ac_draw = NULL; - ret = PTR_ERR(ac_draw); } if (pdata->is_ac_online) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/