Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755199Ab0HXNdK (ORCPT ); Tue, 24 Aug 2010 09:33:10 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:55676 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607Ab0HXNdI (ORCPT ); Tue, 24 Aug 2010 09:33:08 -0400 Message-ID: <4C73CA24.3060707@fusionio.com> Date: Tue, 24 Aug 2010 15:33:24 +0200 From: Jens Axboe MIME-Version: 1.0 To: Peter Zijlstra CC: David Rientjes , Andrew Morton , Neil Brown , Alasdair G Kergon , Chris Mason , Steven Whitehouse , Jan Kara , Frederic Weisbecker , "linux-raid@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "cluster-devel@redhat.com" , "linux-ext4@vger.kernel.org" , "reiserfs-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc References: <1282656558.2605.2742.camel@laptop> In-Reply-To: <1282656558.2605.2742.camel@laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 24 On 2010-08-24 15:29, Peter Zijlstra wrote: > On Tue, 2010-08-24 at 03:50 -0700, David Rientjes wrote: >> These were added as helper functions for documentation and auditability. >> No future callers should be added. > > git grep GFP_NOFAIL isn't auditable enough? > > might as well declare these functions depricated if you really want to > do this. Agree, adding a helper function would seem to be going in the reverse direction imho. Nobody will read that comment on top of the function. Should be possible to warn at build time for anyone using __GFP_NOFAIL without wrapping it in a function. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/