DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=hyIxM6bDea2p/NiTj3wHQMQlHVuM1niZW1bwgPuAXbX3gYsresmf7MaZtTvZZ04Rsh
         QIVFoizOasPwirNhR4bMDMiwxT4NDBiI+Hu03rz5a406fnseT54sppYzEemur/4OsjBz
         +v1mRSsissxNykT9exGyZO4Zf8m0M222o6QvY=
MIME-Version: 1.0
In-Reply-To: <19571.31677.407213.580581@ipc1.ka-ro>
References: <1281956870-12463-1-git-send-email-s.hauer@pengutronix.de>
	<1281956870-12463-4-git-send-email-s.hauer@pengutronix.de>
	<20100823125704.GU27749@pengutronix.de>
	<19571.31677.407213.580581@ipc1.ka-ro>
Date: Tue, 24 Aug 2010 17:01:43 +0200
Message-ID: <AANLkTik9sYW9My1SDUV0zvNZaR+UME9z5Z1EMep98Dy-@mail.gmail.com>
Subject: Re: [PATCH 3/3 v2] dmaengine: Add Freescale i.MX SDMA support
From: Linus Walleij <linus.ml.walleij@gmail.com>
To: =?ISO-8859-1?Q?Lothar_Wa=DFmann?= <LW@karo-electronics.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org,
        Dan Williams <dan.j.williams@intel.com>,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 723
Lines: 21

2010/8/24 Lothar Wa?mann <LW@karo-electronics.de>:
> [Sacha]
> [...]
>> +static int __devinit sdma_probe(struct platform_device *pdev)
>>
> __devinit/__devexit is for hot-pluggable devices. I don't think the
> SDMA controller is hot-pluggable, so __init/__exit could be used here.

Then the .probe member has to be removed from the
struct platform_driver and platform_driver_probe() used instead
of platform_driver_register().

But it'd work fine I think.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/