Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756054Ab0HXVoZ (ORCPT ); Tue, 24 Aug 2010 17:44:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755485Ab0HXVoY (ORCPT ); Tue, 24 Aug 2010 17:44:24 -0400 Message-ID: <4C743D2E.7090803@redhat.com> Date: Tue, 24 Aug 2010 18:44:14 -0300 From: Mauro Carvalho Chehab User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100803 Red Hat/3.1.2-1.el6 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: Ingo Molnar CC: Randy Dunlap , Linus Torvalds , Andrew Morton , Linux Media Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency References: <4C643A08.3000605@redhat.com> <20100824084528.GA26618@elte.hu> <4C73E46B.8050203@oracle.com> <20100824193039.GA20425@elte.hu> In-Reply-To: <20100824193039.GA20425@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3321 Lines: 104 Em 24-08-2010 16:30, Ingo Molnar escreveu: > > * Randy Dunlap wrote: > >> On 08/24/10 01:45, Ingo Molnar wrote: >>> >>> * Mauro Carvalho Chehab wrote: >>> >>>> Linus, >>>> >>>> Please pull from: >>>> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus >>>> >>>> For 3 build fixes. >>>> >>>> Cheers, >>>> Mauro. >>>> >>>> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: >>>> >>>> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700) >>>> >>>> are available in the git repository at: >>>> >>>> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus >>>> >>>> Mauro Carvalho Chehab (2): >>>> V4L/DVB: Fix IR_CORE dependencies >>>> V4L/DVB: fix Kconfig to depends on VIDEO_IR >>>> >>>> Randy Dunlap (1): >>>> V4L/DVB: v4l2-ctrls.c: needs to include slab.h >>> >>> FYI, there's one more IR_CORE related build bug which triggers >>> frequently in randconfig tests - see the fix below. >>> >>> Thanks, >>> >>> Ingo >>> >>> -------------------> >>> From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 >>> From: Ingo Molnar >>> Date: Tue, 24 Aug 2010 10:41:33 +0200 >>> Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency >>> >>> This build bug triggers: >>> >>> drivers/built-in.o: In function `mantis_exit': >>> (.text+0x377413): undefined reference to `ir_input_unregister' >>> drivers/built-in.o: In function `mantis_input_init': >>> (.text+0x3774ff): undefined reference to `__ir_input_register' >>> >>> If MANTIS_CORE is enabled but IR_CORE is not. Add the correct >>> dependency. >>> >>> Signed-off-by: Ingo Molnar >>> --- >>> drivers/media/dvb/mantis/Kconfig | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig >>> index decdeda..fd0830e 100644 >>> --- a/drivers/media/dvb/mantis/Kconfig >>> +++ b/drivers/media/dvb/mantis/Kconfig >>> @@ -1,6 +1,6 @@ >>> config MANTIS_CORE >>> tristate "Mantis/Hopper PCI bridge based devices" >>> - depends on PCI && I2C && INPUT >>> + depends on PCI && I2C && INPUT && IR_CORE >>> >>> help >>> Support for PCI cards based on the Mantis and Hopper PCi bridge. >> >> >> Acked-by: Randy Dunlap >> http://lkml.org/lkml/2010/8/17/341 > > Your patch came first :-) > > Btw., the reason i missed your patch is that i grepped lkml for the > static build failure - while your changelog contained the modular one. > Oh well :) I've added this patch earlier today on my tree: http://git.linuxtv.org/media_tree.git?a=commit;h=3a057c36346f60bd0fb4fe7d7a68c4d931d8768f and the other IR_CORE fixup at staging/tm6000: http://git.linuxtv.org/media_tree.git?a=commit;h=926a2496438f44268130f72f5e102dcac484573d I'll be sending them today to my linux-next tree and likely tomorrow to upstream, together with a few other fixes. > > Thanks, > > Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/