Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756217Ab0HYBw0 (ORCPT ); Tue, 24 Aug 2010 21:52:26 -0400 Received: from smtp-out.google.com ([74.125.121.35]:48791 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751594Ab0HYBwX (ORCPT ); Tue, 24 Aug 2010 21:52:23 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=vVYjmlaxgimkK6bVf8+f0TClCCjJ8ZuO/ZK07XHeFqxP56lxp6cXH6xvlG/3oVi/hU wDs6SiADz3c9uhwS6E4g== MIME-Version: 1.0 In-Reply-To: <20100825104240.7dbaba6a.kamezawa.hiroyu@jp.fujitsu.com> References: <20100820185552.426ff12e.kamezawa.hiroyu@jp.fujitsu.com> <20100820185816.1dbcd53a.kamezawa.hiroyu@jp.fujitsu.com> <20100825092010.cfe91b1a.kamezawa.hiroyu@jp.fujitsu.com> <20100825093747.24085b28.kamezawa.hiroyu@jp.fujitsu.com> <20100825100310.ba3fd27e.kamezawa.hiroyu@jp.fujitsu.com> <20100825104240.7dbaba6a.kamezawa.hiroyu@jp.fujitsu.com> Date: Tue, 24 Aug 2010 18:52:20 -0700 Message-ID: Subject: Re: [PATCH 1/5] cgroup: ID notification call back From: Paul Menage To: KAMEZAWA Hiroyuki Cc: linux-mm@kvack.org, "nishimura@mxp.nes.nec.co.jp" , "balbir@linux.vnet.ibm.com" , gthelen@google.com, m-ikeda@ds.jp.nec.com, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , kamezawa.hiroyuki@gmail.com, "lizf@cn.fujitsu.com" Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 23 On Tue, Aug 24, 2010 at 6:42 PM, KAMEZAWA Hiroyuki wrote: > > Hmm, but placing css and subsystem's its own structure in different cache line > can increase cacheline/TLB miss, I think. My patch shouldn't affect the memory placement of any structures. struct cgroup_subsys_state is still embedded in the per-subsystem state. > > Do we have to call alloc_css_id() in kernel/cgroup.c ? I guess not, if no-one's using it except for memcg. The general approach of allocating the CSS in cgroup.c rather than in every subsystem is something that I'd like to do separately, though. Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/