Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234Ab0HYGiM (ORCPT ); Wed, 25 Aug 2010 02:38:12 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39339 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201Ab0HYGiK (ORCPT ); Wed, 25 Aug 2010 02:38:10 -0400 Date: Tue, 24 Aug 2010 23:41:32 -0700 From: Andrew Morton To: Huang Shijie Cc: linux-kernel@vger.kernel.org, Jesse Barnes , Bjorn Helgaas Subject: Re: [PATCH] avoiding the same resource to be inserted Message-Id: <20100824234132.a0f1cec3.akpm@linux-foundation.org> In-Reply-To: References: <1281974138-5553-1-git-send-email-shijie8@gmail.com> <20100824164622.a3b2c1ed.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 16 On Wed, 25 Aug 2010 13:03:55 +0800 Huang Shijie wrote: > On Wed, Aug 25, 2010 at 7:46 AM, Andrew Morton > wrote: > > I think WARN_ON() is not power enough. If the CONFIG_BUG is not > defined, the warning message may not be printed. So I think using a > directly printk() here is better. No, WARN_ON() is good. It gives us a backtrace and identifies the buggy code. Only maniacs turn off CONFIG_BUG. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/