From: Arnd Bergmann <arnd@arndb.de>
To: Namhyung Kim <namhyung@gmail.com>
Subject: Re: [PATCH 2/3 RESEND] ptrace: cleanup address space conversion on ptrace_request()
Date: Wed, 25 Aug 2010 13:42:46 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.35-16-generic; KDE/4.3.2; x86_64; ; )
Cc: Christoph Hellwig <hch@infradead.org>, Roland McGrath <roland@redhat.com>,
        Oleg Nesterov <oleg@redhat.com>, linux-kernel@vger.kernel.org
References: <201008222206.18523.arnd@arndb.de> <201008241345.06507.arnd@arndb.de> <87sk23w2sn.fsf@gmail.com>
In-Reply-To: <87sk23w2sn.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201008251342.46107.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 853
Lines: 21

On Wednesday 25 August 2010, Namhyung Kim wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> > I don't think we ever rely on 'data' being signed, and user space
> > sees it as 'void *' anyway, so it should be possible to just turn
> > it into 'unsigned long'.
> >
> 
> After I've checked all arch_ptrace() code, I can think there is no specific
> reason @addr and @data to be signed long types. Most of archs use them
> as if they were unsigned. So I'll prepare a patch series to change this
> and some cleanups of ptrace_request() and all of arch_ptrace() if no
> objection exists.

Sounds good to me.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/