Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752451Ab0HZDMU (ORCPT ); Wed, 25 Aug 2010 23:12:20 -0400 Received: from smtp-out.google.com ([216.239.44.51]:25736 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010Ab0HZDMR (ORCPT ); Wed, 25 Aug 2010 23:12:17 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=dzST9JDd8nedPG98MUjZ+BSGOnQFKuqzAHSROuUEJlvGXQkjRJjlyEanINgdMbGEj Exlx+X2pNlDgnE1HMA09Q== Date: Wed, 25 Aug 2010 20:12:04 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Christoph Lameter cc: Peter Zijlstra , Dave Chinner , "Ted Ts'o" , Jens Axboe , Andrew Morton , Neil Brown , Alasdair G Kergon , Chris Mason , Steven Whitehouse , Jan Kara , Frederic Weisbecker , "linux-raid@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "cluster-devel@redhat.com" , "linux-ext4@vger.kernel.org" , "reiserfs-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc In-Reply-To: Message-ID: References: <1282656558.2605.2742.camel@laptop> <4C73CA24.3060707@fusionio.com> <20100825112433.GB4453@thunk.org> <1282736132.2605.3563.camel@laptop> <20100825115709.GD4453@thunk.org> <1282740516.2605.3644.camel@laptop> <20100825132417.GQ31488@dastard> <1282743342.2605.3707.camel@laptop> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 20 On Wed, 25 Aug 2010, Christoph Lameter wrote: > > Right, I thought you said the slab layer passes __GFP_NOFAIL when there's > > no objects available. > > Yes, the slab layer calls the page allocator when there are no objects > available and passes the __GFP_NOFAIL that the user may have set in the > call to the page allocator. > > Why then add new functions that do the same? > Because we can remove the flag, remove branches from the page allocator slowpath, and none of these allocations actually are dependent on __GFP_NOFAIL since they are all under PAGE_ALLOC_COSTLY_ORDER. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/