Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190Ab0HZEWI (ORCPT ); Thu, 26 Aug 2010 00:22:08 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:47086 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116Ab0HZEWF (ORCPT ); Thu, 26 Aug 2010 00:22:05 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Neil Brown Subject: Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio Cc: kosaki.motohiro@jp.fujitsu.com, Wu Fengguang , Con Kolivas , Jan Kara , Rik van Riel , Peter Zijlstra , Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "david@fromorbit.com" , "hch@lst.de" , "axboe@kernel.dk" In-Reply-To: <20100826113649.687b453a@notabene> References: <20100826012945.GA7859@localhost> <20100826113649.687b453a@notabene> Message-Id: <20100826132046.F670.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 26 Aug 2010 13:22:02 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 28 > > writeback: remove the internal 5% low bound on dirty_ratio > > > > The dirty_ratio was silently limited in global_dirty_limits() to >= 5%. > > This is not a user expected behavior. And it's inconsistent with > > calc_period_shift(), which uses the plain vm_dirty_ratio value. > > > > Let's rip the internal bound. > > > > At the same time, fix balance_dirty_pages() to work with the > > dirty_thresh=0 case. This allows applications to proceed when > > dirty+writeback pages are all cleaned. > > And ">" fits with the name "exceeded" better than ">=" does. I think it is > an aesthetic improvement as well as a functional one. > > Reviewed-by: NeilBrown I agree :) Reviewed-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/