Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225Ab0HZGRq (ORCPT ); Thu, 26 Aug 2010 02:17:46 -0400 Received: from mga01.intel.com ([192.55.52.88]:23585 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874Ab0HZGRo (ORCPT ); Thu, 26 Aug 2010 02:17:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.56,272,1280732400"; d="scan'208";a="831874131" Date: Wed, 25 Aug 2010 23:08:22 -0700 From: Fenghua Yu To: Jin Dongming Cc: "Yu, Fenghua" , mingo Redhat , "Brown, Len" , Guenter Roeck , "H. Peter Anvin" , Thomas Gleixner , Hidetoshi Seto , "lm-sensors@lm-sensors.org" , LKLM Subject: Re: [Patch-next] Package Level Power limit: fix the generation of package_power_limit_count sysfile. Message-ID: <20100826060822.GA15021@fenghua-desk.sc.intel.com> References: <4C75D3C4.6040802@np.css.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C75D3C4.6040802@np.css.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1679 Lines: 45 On Wed, Aug 25, 2010 at 07:39:00PM -0700, Jin Dongming wrote: > > This patch is used for fixing it. But I have not confirmed this patch > because I don't have such machine. > > Signed-off-by: Jin Dongming > --- > arch/x86/kernel/cpu/mcheck/therm_throt.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c > index d9368ee..169d880 100644 > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c > @@ -216,7 +216,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev, > err = sysfs_add_file_to_group(&sys_dev->kobj, > &attr_core_power_limit_count.attr, > thermal_attr_group.name); > - if (cpu_has(c, X86_FEATURE_PTS)) > + if (cpu_has(c, X86_FEATURE_PTS)) { > err = sysfs_add_file_to_group(&sys_dev->kobj, > &attr_package_throttle_count.attr, > thermal_attr_group.name); > @@ -224,6 +224,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev, > err = sysfs_add_file_to_group(&sys_dev->kobj, > &attr_package_power_limit_count.attr, > thermal_attr_group.name); > + } > > return err; > } The argument is right. A concise message (e.g. missing { and }) would be better. Format of this patch is broken. It would be applied to kernel tree. Could you generate a patch with right format? Thanks. -Fenghua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/