Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848Ab0HZJyJ (ORCPT ); Thu, 26 Aug 2010 05:54:09 -0400 Received: from mail-in-10.arcor-online.net ([151.189.21.50]:45369 "EHLO mail-in-10.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000Ab0HZJyG (ORCPT ); Thu, 26 Aug 2010 05:54:06 -0400 X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-12.arcor-online.net 061DF3D8001 Date: Thu, 26 Aug 2010 11:53:59 +0200 (CEST) From: Bodo Eggert <7eggert@gmx.de> To: Valerie Aurora cc: 7eggert@gmx.de, David Woodhouse , Miklos Szeredi , jack@suse.cz, agruen@suse.de, viro@zeniv.linux.org.uk, jblunck@suse.de, hch@infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, linux-ext4@vger.kernel.org Subject: Re: [PATCH 14/38] fallthru: ext2 fallthru support In-Reply-To: <20100824172108.GA28718@shell> Message-ID: References: <20100824172108.GA28718@shell> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 27 On Tue, 24 Aug 2010, Valerie Aurora wrote: > On Thu, Aug 19, 2010 at 01:24:07AM +0200, Bodo Eggert wrote: >> Miklos Szeredi wrote: >>> On Tue, 17 Aug 2010, Valerie Aurora wrote: >>> get_unlinked_inode() is a great idea. But I feel that individual >>> inodes for each fallthrough is excessive. It'll make the first >>> readdir() really really expensive and wastes a lot of disk and memory >>> for no good reason. >>> >>> Not sure how to fix the hard link limits problem though... >> >> Do a hardlink if you can create a hard link, otherwise use a fresh inode >> and use that for the next hardlink(s). > > Bleah! Then you have a code path that is only tested when you hit > LINK_MAX. Sounds like a recipe for bugs for me. You'll also hit it while creating the first whiteout, maybe on creating the first whiteout since mounting, and on filesystems not supporting hardlinks (are there some that support attributes but not hardlinks?). Maybe it will be possible to create immutable whiteout inodes, too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/