To: linux-kernel@vger.kernel.org
From: =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
Subject: Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
Date: Thu, 26 Aug 2010 14:34:55 +0200
Organization: m
Message-ID: <87aao9y2kw.fsf@nemi.mork.no>
References: <4C643A08.3000605@redhat.com> <20100824084528.GA26618@elte.hu>
	<4C73E46B.8050203@oracle.com> <20100824193039.GA20425@elte.hu>
	<4C743D2E.7090803@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux)
Cancel-Lock: sha1:EtsOOOe3ujoP9DGxwnvQD8p9pTs=
Cc: linux-media@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1476
Lines: 28

I wonder, am I really the only one who find it somewhat strange that
it's necessary to break the mantis driver by doing changes to code which
is not used at all?  Yes, mantis_input.c may be linked into mantis_core,
so it is capable of breaking the build, but there is *nothing* calling
the code.

IMHO mantis_input.c should be removed unless it can be fixed up enough
to be enabled, but one would have to know why it was disabled in the
first place to do that.  Dead code can always be ressurrected later if
someone is willing to work on it.  This completely unnecessary
dependency bug gives you at least one good reason why keeping dead code
is bad.

(Keeping the code might have been considered if it was likely to be used
in the near future, but this is not the case given that you do not
currently accept any patches actually improving the mantis driver.)

It's not that this bug is so bad or nothing.  I'm just puzzled by your
development priorities, which is the direct cause of this bug.

Let me know if you are going to start accepting patches for the mantis
driver (the best way is by doing something with the patches already
posted), and I will prepare and test a patch removing mantis_input.c

Just my €0.02


Bjørn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/