Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754167Ab0HZPm1 (ORCPT ); Thu, 26 Aug 2010 11:42:27 -0400 Received: from mail.vyatta.com ([76.74.103.46]:46169 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309Ab0HZPmW (ORCPT ); Thu, 26 Aug 2010 11:42:22 -0400 Date: Thu, 26 Aug 2010 08:42:19 -0700 From: Stephen Hemminger To: Masayuki Ohtake Cc: LKML , ML netdev , Greg Rose , Maxime Bizon , Kristoffer Glembo , Ralf Baechle , John Linn , Randy Dunlap , "David S. Miller" , MeeGo , "Wang, Qi" , "Wang, Yong Y" , Andrew , Intel OTC , "Foster, Margie" , Toshiharu Okada , Tomoya Morinaga , Takahiro Shimizu Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH Message-ID: <20100826084219.322f43f9@nehalam> In-Reply-To: <4C763A67.5040107@dsn.okisemi.com> References: <4C763A67.5040107@dsn.okisemi.com> Organization: Vyatta X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 36 On Thu, 26 Aug 2010 18:56:55 +0900 Masayuki Ohtake wrote: > + > +static struct ethtool_ops pch_gbe_ethtool_ops = { > + .get_settings = pch_gbe_get_settings, > + .set_settings = pch_gbe_set_settings, > + .get_drvinfo = pch_gbe_get_drvinfo, > + .get_regs_len = pch_gbe_get_regs_len, > + .get_regs = pch_gbe_get_regs, > + .get_wol = pch_gbe_get_wol, > + .set_wol = pch_gbe_set_wol, > + .nway_reset = pch_gbe_nway_reset, > + .get_link = ethtool_op_get_link, > + .get_ringparam = pch_gbe_get_ringparam, > + .set_ringparam = pch_gbe_set_ringparam, > + .get_pauseparam = pch_gbe_get_pauseparam, > + .set_pauseparam = pch_gbe_set_pauseparam, > + .get_rx_csum = pch_gbe_get_rx_csum, > + .set_rx_csum = pch_gbe_set_rx_csum, > + .get_tx_csum = pch_gbe_get_tx_csum, > + .set_tx_csum = pch_gbe_set_tx_csum, > + .get_strings = pch_gbe_get_strings, > + .get_ethtool_stats = pch_gbe_get_ethtool_stats, > + .get_sset_count = pch_gbe_get_sset_count, > +}; > + Should be const -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/