Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754573Ab0H0AWs (ORCPT ); Thu, 26 Aug 2010 20:22:48 -0400 Received: from smtp-02.mandic.com.br ([200.225.81.133]:52165 "EHLO smtp-02.mandic.com.br" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540Ab0H0AWp (ORCPT ); Thu, 26 Aug 2010 20:22:45 -0400 Message-ID: <4C77054F.8030104@cesarb.net> Date: Thu, 26 Aug 2010 21:22:39 -0300 From: Cesar Eduardo Barros User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Thunderbird/3.1.2 MIME-Version: 1.0 To: Alan Cox CC: Jesse Barnes , Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] intel_ips: quieten "power or thermal limit exceeded" messages References: <4C74686D.8090707@cesarb.net> <1282865341-17607-1-git-send-email-cesarb@cesarb.net> <20100827011853.3faef5e7@lxorguk.ukuu.org.uk> In-Reply-To: <20100827011853.3faef5e7@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 35 Em 26-08-2010 21:18, Alan Cox escreveu: > On Thu, 26 Aug 2010 20:29:01 -0300 > Cesar Eduardo Barros wrote: > >> On my Dell Inspiron N4010, one of these messages is printed every five >> seconds. Change both to dev_dbg to quieten them even more. > > It's not the kind of thing you want to quieten since in most cases it is > stuff you want to know about. Isn't it a normal thing, however? If I understand it correctly, this driver allows you to use a bit more power but throttles back if you are using too much or it gets too hot. Thus, there should be nothing wrong or even unusual with the situations where these messages appear. >> if (ret) >> - dev_info(&ips->dev->dev, >> + dev_dbg(&ips->dev->dev, >> "MCP power or thermal limit exceeded\n"); > > Probably better to ratelimit it. Being told it occurs is important, being > told every five seconds is indeed excessive. Agreed. Even if it does not happen when idle, it should happen a lot while playing a CPU-heavy and GPU-heavy 3D game. -- Cesar Eduardo Barros cesarb@cesarb.net cesar.barros@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/