Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156Ab0H0NCc (ORCPT ); Fri, 27 Aug 2010 09:02:32 -0400 Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:4472 "EHLO TX2EHSOBE007.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752708Ab0H0NC1 (ORCPT ); Fri, 27 Aug 2010 09:02:27 -0400 X-SpamScore: -14 X-BigFish: VPS-14(zzbb2cK1432N98dNzz1202hzz8275dhz32i2a8h61h) X-Spam-TCS-SCL: 0:0 X-WSS-ID: 0L7TARU-02-AOS-02 X-M-MSG: Date: Fri, 27 Aug 2010 14:59:56 +0200 From: Robert Richter To: Matt Fleming CC: "linux-kernel@vger.kernel.org" , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" Subject: Re: [PATCH V2 3/4] oprofile: Abstract the perf-events backend Message-ID: <20100827125956.GK22783@erda.amd.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Reverse-DNS: ausb3extmailp02.amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 33 On 26.08.10 15:09:18, Matt Fleming wrote: > Move the perf-events backend from arch/arm/oprofile into > drivers/oprofile so that the code can be shared between architectures. > > This allows each architecture to maintain only a single copy of the > PMU accessor functions instead of one for both perf and OProfile. It > also becomes possible for other architectures to delete much of their > OProfile code in favour of the common code now available in > drivers/oprofile/oprofile_perf.c. > > Signed-off-by: Matt Fleming > --- > arch/arm/oprofile/Makefile | 4 + > arch/arm/oprofile/common.c | 215 +++----------------------------------- > drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++++ > include/linux/oprofile.h | 12 ++ > 4 files changed, 242 insertions(+), 198 deletions(-) > create mode 100644 drivers/oprofile/oprofile_perf.c Could we split this patch in 2 for better review? One that only moves the code and a 2nd that changes it. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/