Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847Ab0H0NzA (ORCPT ); Fri, 27 Aug 2010 09:55:00 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:60484 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753616Ab0H0Ny6 (ORCPT ); Fri, 27 Aug 2010 09:54:58 -0400 Subject: Re: [PATCH 03/24] arm: mm: add proc info for ScorpionMP From: Catalin Marinas To: Jeff Ohlstein Cc: Russell King , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Walker , Tony Lindgren , "Kirill A. Shutemov" In-Reply-To: <1282712273-344-4-git-send-email-johlstei@codeaurora.org> References: <1282712273-344-4-git-send-email-johlstei@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Organization: ARM Limited Date: Fri, 27 Aug 2010 14:54:40 +0100 Message-ID: <1282917280.26355.33.camel@e102109-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 27 Aug 2010 13:54:40.0788 (UTC) FILETIME=[65384D40:01CB45EF] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 40 On Wed, 2010-08-25 at 05:57 +0100, Jeff Ohlstein wrote: > From: Daniel Walker > > ScorpionMP does not have the SMP/nAMP and TLB ops broadcasting bits in > ACTLR. > > Signed-off-by: Daniel Walker > Signed-off-by: Jeff Ohlstein > --- > arch/arm/mm/proc-v7.S | 24 ++++++++++++++++++++++++ > 1 files changed, 24 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S > index 7aaf88a..98fd7e5 100644 > --- a/arch/arm/mm/proc-v7.S > +++ b/arch/arm/mm/proc-v7.S > @@ -196,6 +196,7 @@ __v7_setup: > orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and > mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting > #endif > +__v7_msm_setup: > adr r12, __v7_setup_stack @ the local stack > stmia r12, {r0-r5, r7, r9, r11, lr} > bl v7_flush_dcache_all It may be better to move the generic __v7_setup here and have a specific entry for ARM Ltd cores (mask 0xff0f0000 and value 0x410f0000). In general, I would have liked a different way (still ID-based) of handling such issues without duplicating the whole structure. But I see this becoming the standard as proc-v6.S follows it as well. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/