Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754421Ab0H0UCp (ORCPT ); Fri, 27 Aug 2010 16:02:45 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:54999 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758Ab0H0UCn (ORCPT ); Fri, 27 Aug 2010 16:02:43 -0400 Date: Fri, 27 Aug 2010 13:02:33 -0700 From: Andrew Morton To: Chris Ball Cc: Guennadi Liakhovetski , linux-kernel@vger.kernel.org, "linux-sh@vger.kernel.org" , Dan Williams , Greg Kroah-Hartman , linux-mmc@vger.kernel.org Subject: Re: [PATCH RESEND] initialise DMA engine before MMC Message-Id: <20100827130233.893e7151.akpm@linux-foundation.org> In-Reply-To: <20100827194939.GJ23079@void.printf.net> References: <20100827194939.GJ23079@void.printf.net> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1572 Lines: 48 On Fri, 27 Aug 2010 20:49:39 +0100 Chris Ball wrote: > Hi, > > Andrew, mind taking this one? > > From: Guennadi Liakhovetski > Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST) > > To use DMA engine based DMA with MMC in a non-modular build, the DMA > engine has to initialise before MMC. > > Signed-off-by: Guennadi Liakhovetski > Acked-by: Dan Williams > --- > diff --git a/drivers/Makefile b/drivers/Makefile > index 91874e0..b713e75 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/ > obj-y += lguest/ > obj-$(CONFIG_CPU_FREQ) += cpufreq/ > obj-$(CONFIG_CPU_IDLE) += cpuidle/ > +obj-$(CONFIG_DMA_ENGINE) += dma/ > obj-$(CONFIG_MMC) += mmc/ > obj-$(CONFIG_MEMSTICK) += memstick/ > obj-$(CONFIG_NEW_LEDS) += leds/ > @@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/ > obj-$(CONFIG_SUPERH) += sh/ > obj-$(CONFIG_ARCH_SHMOBILE) += sh/ > obj-$(CONFIG_GENERIC_TIME) += clocksource/ > -obj-$(CONFIG_DMA_ENGINE) += dma/ > obj-$(CONFIG_DCA) += dca/ > obj-$(CONFIG_HID) += hid/ > obj-$(CONFIG_PPC_PS3) += ps3/ erk, doing this via link ordering isn't nice. It would be better to express this dependency via initcall levels - core_initcall() or something. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/