Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751651Ab0H1Ffm (ORCPT ); Sat, 28 Aug 2010 01:35:42 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:45510 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783Ab0H1Ffk (ORCPT ); Sat, 28 Aug 2010 01:35:40 -0400 MIME-Version: 1.0 In-Reply-To: <20100827142217.5fccc098@nehalam> References: <1282938138-17844-1-git-send-email-Kyle.D.Moffett@boeing.com> <20100827133825.494b8098@nehalam> <81DAD951-0909-4D3A-8451-AEE3F9B07054@boeing.com> <20100827142217.5fccc098@nehalam> From: Kyle Moffett Date: Sat, 28 Aug 2010 01:35:19 -0400 Message-ID: Subject: Re: [PATCH 2/2] sky2: Add unidirectional fiber link support To: Stephen Hemminger Cc: "Moffett, Kyle D" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 27 On Fri, Aug 27, 2010 at 17:22, Stephen Hemminger wrote: > On Fri, 27 Aug 2010 15:51:58 -0500 "Moffett, Kyle D" wrote: >> Do you have any comments or criticisms of the particular "duplex" method of configuring the unidirectional link support? > > No that is fine, but the FIB doesn't really understand RX only links so I expect users will do stupid things. As far as the chipset is concerned, an "rxonly" link would just be a regular full-duplex forced-mode fiber link. If the user happens to wire up the "transmit" path on such a link and is then surprised when the driver is actually able to use that path, that would seem to be their own problem. I'm considering perhaps fiddling with ARP or routing behavior over txonly/rxonly links, so I'd like to preserve the symmetry even if just for documentation purposes or future optimizations. When I get any applicable review commentary sorted out and worked through, in whose tree should I request inclusion of these 2 patches? Thanks for your comments! Cheers, Kyle Moffett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/