Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752939Ab0H1Qta (ORCPT ); Sat, 28 Aug 2010 12:49:30 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:35329 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168Ab0H1QtR (ORCPT ); Sat, 28 Aug 2010 12:49:17 -0400 Date: Sat, 28 Aug 2010 18:49:15 +0200 (CEST) From: Julia Lawall To: Dan Carpenter Cc: Thomas Dahlmann , kernel-janitors@vger.kernel.org, David Brownell , Greg Kroah-Hartman , linux-geode@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test In-Reply-To: <20100828163725.GI9832@bicker> Message-ID: References: <1283010066-20935-1-git-send-email-julia@diku.dk> <1283010066-20935-3-git-send-email-julia@diku.dk> <20100828163725.GI9832@bicker> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 31 On Sat, 28 Aug 2010, Dan Carpenter wrote: > On Sat, Aug 28, 2010 at 05:41:01PM +0200, Julia Lawall wrote: > > This is a guess as to what the code should be. Perhaps something else > > should have been tested instead. > > > > drivers/usb/gadget/amd5536udc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c > > index 731150d..6c40c99 100644 > > --- a/drivers/usb/gadget/amd5536udc.c > > +++ b/drivers/usb/gadget/amd5536udc.c > > @@ -203,7 +203,7 @@ static void print_regs(struct udc *dev) > > DBG(dev, "DMA mode = PPBNDU (packet per buffer " > > "WITHOUT desc. update)\n"); > > dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU"); > > - } else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) { > > + } else if (use_dma && use_dma_ppb_du) { > > > My guess is that "use_dma_ppb" was intended. Thanks. I made this change. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/