Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318Ab0H2MxG (ORCPT ); Sun, 29 Aug 2010 08:53:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28159 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119Ab0H2MxF (ORCPT ); Sun, 29 Aug 2010 08:53:05 -0400 Message-ID: <4C7A5821.3010007@redhat.com> Date: Sun, 29 Aug 2010 15:52:49 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: "H. Peter Anvin" CC: Matteo Croce , Thomas Backlund , linux-kernel@vger.kernel.org, Alan Cox , Natale Vinto Subject: Re: AMD Geode NOPL emulation for kernel 2.6.36-rc2 References: <4C780888.9000301@zytor.com> <4C7824F2.1050709@mandriva.org> <4C784544.2010305@zytor.com> In-Reply-To: <4C784544.2010305@zytor.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 26 On 08/28/2010 02:07 AM, H. Peter Anvin wrote: > On 08/27/2010 02:32 PM, Matteo Croce wrote: >> can I ignore the return value when I expect val to be non zero? >> the doc says: "On error, the variable @x is set to zero." > No. You need to deliver a page fault to the application in this case. > > The *real* test for this kind of crap is correct page fault behavior, > and so forth. > > Also, at the very least you need to check for: > > - CS == USER_CS Is that mandated by the ABI? Is it illegal for an application to load a segment with a nonzero base into the LDT and use it for CS? What about vm86? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/