Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754078Ab0H2VYn (ORCPT ); Sun, 29 Aug 2010 17:24:43 -0400 Received: from smtp-out.google.com ([216.239.44.51]:42406 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292Ab0H2VYm (ORCPT ); Sun, 29 Aug 2010 17:24:42 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=DusaSgI7cbLSB37X+LsPh4H9la6zV5YaGx7YIiaIQuVE99eninr0cGs2Pn5mtbPT5c VXsJMn1+AblnzgvigzWw== MIME-Version: 1.0 In-Reply-To: <4C7ABD14.9050207@redhat.com> References: <1283096628-4450-1-git-send-email-minchan.kim@gmail.com> <4C7ABD14.9050207@redhat.com> Date: Sun, 29 Aug 2010 14:23:31 -0700 Message-ID: Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system From: Ying Han To: Rik van Riel Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , Venkatesh Pallipadi , KOSAKI Motohiro , Johannes Weiner Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 46 On Sun, Aug 29, 2010 at 1:03 PM, Rik van Riel wrote: > On 08/29/2010 01:45 PM, Ying Han wrote: > >> There are few other places in vmscan where we check nr_swap_pages and >> inactive_anon_is_low. Are we planning to change them to use >> total_swap_pages >> to be consistent ? > > If that makes sense, maybe the check can just be moved into > inactive_anon_is_low itself? That was the initial patch posted, instead we changed to use total_swap_pages instead. How this patch looks: @@ -1605,6 +1605,9 @@ static int inactive_anon_is_low(struct zone *zone, struct scan_control *sc) { int low; + if (total_swap_pages <= 0) + return 0; + if (scanning_global_lru(sc)) low = inactive_anon_is_low_global(zone); else @@ -1856,7 +1859,7 @@ static void shrink_zone(int priority, struct zone *zone, * Even if we did not try to evict anon pages at all, we want to * rebalance the anon lru active/inactive ratio. */ - if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0) + if (inactive_anon_is_low(zone, sc)) shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); throttle_vm_writeout(sc->gfp_mask); --Ying > > -- > All rights reversed > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/