Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754052Ab0H2W0X (ORCPT ); Sun, 29 Aug 2010 18:26:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57915 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753960Ab0H2W0W (ORCPT ); Sun, 29 Aug 2010 18:26:22 -0400 Message-ID: <4C7ADE7A.2040909@redhat.com> Date: Sun, 29 Aug 2010 18:26:02 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1 MIME-Version: 1.0 To: Ying Han CC: Minchan Kim , Andrew Morton , linux-mm , LKML , Venkatesh Pallipadi , KOSAKI Motohiro , Johannes Weiner Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system References: <1283096628-4450-1-git-send-email-minchan.kim@gmail.com> <4C7ABD14.9050207@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 30 On 08/29/2010 05:23 PM, Ying Han wrote: > On Sun, Aug 29, 2010 at 1:03 PM, Rik van Riel wrote: >> On 08/29/2010 01:45 PM, Ying Han wrote: >> >>> There are few other places in vmscan where we check nr_swap_pages and >>> inactive_anon_is_low. Are we planning to change them to use >>> total_swap_pages >>> to be consistent ? >> >> If that makes sense, maybe the check can just be moved into >> inactive_anon_is_low itself? > > That was the initial patch posted, instead we changed to use > total_swap_pages instead. How this patch looks: Looks good to me. It could use a comment along the lines of: /* * No sense scanning the anon lists if we have no swap space. */ ... and, of course, your signed-off-by :) -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/