Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634Ab0H2Xi7 (ORCPT ); Sun, 29 Aug 2010 19:38:59 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:53544 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753905Ab0H2Xi6 convert rfc822-to-8bit (ORCPT ); Sun, 29 Aug 2010 19:38:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=e1zptaFfYXQCC8rH0volefRqHQ4BP1iDw6Q6t6Y9Ijl9M34MvPyrqfOWkFaLy35vkz 3ivulmknlkNhQapM4wVDBwVYOh5X2rNmqGcnToswnkweJt6GY/4qiHOg2tSCnobsZq2a Xic4S3qj9RqDXyRBnKqLVrj1xTRuUs0yaWHeo= MIME-Version: 1.0 In-Reply-To: References: <1283011478-27237-1-git-send-email-brgerst@gmail.com> <1283011478-27237-11-git-send-email-brgerst@gmail.com> Date: Sun, 29 Aug 2010 19:38:57 -0400 Message-ID: Subject: Re: [PATCH 10/11] x86: Remove unnecessary ifdefs from i387 code. From: Brian Gerst To: Pekka Enberg Cc: hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 32 On Sun, Aug 29, 2010 at 3:00 PM, Pekka Enberg wrote: > On Sat, Aug 28, 2010 at 7:04 PM, Brian Gerst wrote: >> Remove ifdefs for code that the compiler can optimize away on 64-bit. >> >> Signed-off-by: Brian Gerst > >> @@ -74,10 +74,8 @@ static void __cpuinit init_thread_xstate(void) >> >>        if (cpu_has_fxsr) >>                xstate_size = sizeof(struct i387_fxsave_struct); >> -#ifdef CONFIG_X86_32 >>        else >>                xstate_size = sizeof(struct i387_fsave_struct); >> -#endif >>  } > > I guess this is OK but keep in mind that cpu_has_fsxr is _not_ > optimized by the compiler on 64-bit so the change probably increases > kernel text by few bytes. > > Acked-by: Pekka Enberg > FXSR is a required feature on 64-bit, therefore cpu_has_fxsr is always true. -- Brian Gerst -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/