Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253Ab0H3FGb (ORCPT ); Mon, 30 Aug 2010 01:06:31 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:42101 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753664Ab0H3FGb (ORCPT ); Mon, 30 Aug 2010 01:06:31 -0400 Date: Mon, 30 Aug 2010 07:06:27 +0200 From: Sam Ravnborg To: Andres Salomon Cc: devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, cjb@laptop.org, Mitch Bradley , pgf@laptop.org, linux-kernel@vger.kernel.org, davem@davemloft.net, grant.likely@secretlab.ca, Stephen Neuendorffer Subject: Re: [PATCH 1/9] of: move phandle/ihandle into types.h Message-ID: <20100830050627.GA12153@merkur.ravnborg.org> References: <20100628215407.2017bf2f@debian> <20100829235100.6dcedcb8@debxo> <20100829235352.1744e7e3@debxo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100829235352.1744e7e3@debxo> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1261 Lines: 37 On Sun, Aug 29, 2010 at 11:53:52PM -0400, Andres Salomon wrote: > > We need phandle for some exported sparc headers; of.h isn't an > exported header, and it would be silly to export it when all we > really need is one or two types from it. So, move the phandle/ihandle > definitions into types.h. > > diff --git a/include/linux/types.h b/include/linux/types.h > index 01a082f..26526ea 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -219,6 +219,10 @@ struct ustat { > char f_fpack[6]; > }; > > +/* Basic openboot/openfirmware types */ > +typedef u32 phandle; > +typedef u32 ihandle; > + > #endif /* __KERNEL__ */ The above is inside #ifdef __KERNEL__ / #endif so it is not exported as we drop code protected by __KERNEL__ when we prepare for export. Id addition "phandle" and "ihandle" needs to have two underscores apended as we cannot just add the above to the userspace namespace and expect it to be OK. We do this for many other typers already, see __u32 for example. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/