Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754659Ab0H3Icd (ORCPT ); Mon, 30 Aug 2010 04:32:33 -0400 Received: from borg.asidev.net ([95.141.32.69]:37408 "EHLO borg.asidev.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548Ab0H3Icc (ORCPT ); Mon, 30 Aug 2010 04:32:32 -0400 Message-ID: <4C7B6C9B.2050801@evidence.eu.com> Date: Mon, 30 Aug 2010 10:32:27 +0200 From: Claudio Scordino User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Jesper Nilsson CC: starvik@axis.com, linux-cris-kernel , Alan Cox , Andrew Morton , Hinko Kocevar , Janez Cufer , Andy Whitcroft , Linux Kernel , dev-etrax , linux-serial@vger.kernel.org Subject: Re: [PATCH] CRIS RS485: Check SER_RS485_RTS_BEFORE_SEND before delaying. References: <4C62BD2B.2010508@evidence.eu.com> In-Reply-To: <4C62BD2B.2010508@evidence.eu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 36 Claudio Scordino ha scritto: > Hi Jesper, > > the following patch fixes the usage of the delay in RS485 mode > on the Cris architecture. > > Very recently, the RS485 interface has been fixed by adding two further > fields (see commit 1b6331848b69d1ed165a6bdc75c4046d68767563). > > This patch checks the value of the flag SER_RS485_RTS_BEFORE_SEND before > delaying. Hi all, so far I didn't receive any acknowledgement about this patch. As I said, recently (see commit 1b6331848b69d1ed165a6bdc75c4046d68767563) the Linux RS485 interface has been fixed by adding two missing fields. With the "new" interface, you have to check the SER_RS485_RTS_BEFORE_SEND flag before using the delay_rts_before_send field. The Atmel serial driver has been already fixed (with commit 1b6331848b69d1ed165a6bdc75c4046d68767563 itself). This patch fixes the usage of the interface in the Cris driver too. Best regards, Claudio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/