Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755489Ab0H3MIm (ORCPT ); Mon, 30 Aug 2010 08:08:42 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:57478 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754676Ab0H3MIk (ORCPT ); Mon, 30 Aug 2010 08:08:40 -0400 Message-ID: <4C7B9F14.9080900@mvista.com> Date: Mon, 30 Aug 2010 16:07:48 +0400 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Hannes Reinecke CC: Mike Snitzer , Kiyoshi Ueda , Tejun Heo , michaelc@cs.wisc.edu, James.Bottomley@suse.de, tytso@mit.edu, linux-scsi@vger.kernel.org, jaxboe@fusionio.com, jack@suse.cz, linux-kernel@vger.kernel.org, swhiteho@redhat.com, linux-raid@vger.kernel.org, linux-ide@vger.kernel.org, konishi.ryusuke@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org, vst@vlnb.net, rwheeler@redhat.com, Christoph Hellwig , chris.mason@oracle.com, dm-devel@redhat.com Subject: Re: [RFC] training mpath to discern between SCSI errors References: <20100825155918.GB8509@redhat.com> <4C7B984E.4070802@suse.de> In-Reply-To: <4C7B984E.4070802@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 23 Hello. Hannes Reinecke wrote: > Actually, I think we have two separate issues here: > 1) The need of having more detailed I/O errors even in the fs layer. This > we've already discussed at the LSF, consensus here is to allow other > errors than just 'EIO'. > Instead of Mike's approach I would rather use existing error codes here; > this will make the transition somewhat easier. > Initially I would propose to return 'ENOLINK' for a transport failure, > 'EIO' for a non-retryable failure on the target, and 'ENODEV' for a > retryable failure on the target. Are you sure it's not vice versa: EIO for retryable and ENODEV for non-retryable failures. ENODEV looks more like permanent condition to me. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/