Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755549Ab0H3P01 (ORCPT ); Mon, 30 Aug 2010 11:26:27 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:58634 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753617Ab0H3P00 (ORCPT ); Mon, 30 Aug 2010 11:26:26 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=xRWOoC9/C7N5sMEebTtKVH6sj2+7yq6AYA3v72I+gX5fa9c6DtKUMg8jAbIt7moP3N QSfaIQIuTg3Ha2upHPvgyvonL4sPFcF0/+H8L+Vp+O/6RAIC6Pa/2hOb32e1pkZMJ0z+ fUBvuuvDEqmOSFi6C9hZjBLPgiozu9N5trgBM= MIME-Version: 1.0 In-Reply-To: <201008301725.01424.arnd@arndb.de> References: <1283115995-4734-1-git-send-email-arnd@arndb.de> <201008301428.34979.arnd@arndb.de> <201008301725.01424.arnd@arndb.de> From: Mike Frysinger Date: Mon, 30 Aug 2010 11:26:04 -0400 Message-ID: Subject: Re: [PATCH 4/5] tty/hw: move hardware drivers to drivers/tty/hw To: Arnd Bergmann Cc: Alan Cox , Greg KH , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1730 Lines: 37 On Mon, Aug 30, 2010 at 11:25, Arnd Bergmann wrote: > On Monday 30 August 2010, Mike Frysinger wrote: >> On Mon, Aug 30, 2010 at 08:28, Arnd Bergmann wrote: >> > On Monday 30 August 2010, Alan Cox wrote: >> >> > My impression was that it should actually be converted into an hvc >> >> > driver as a cleanup and moved to drivers/tty/hvc. It can probably >> >> > get reduced to one third of its size if you do that. >> >> >> >> Not sure it makes sense - hvc seems the wrong abstraction. >> > >> > It seems to be very similar to hvc_tile.c in purpose, which is >> > the most trivial driver we have. Why would that not work? >> > >> > Most of bfin_jtag_comm is about interfacing with the tty layer >> > and providing a kernel thread to do the polling, which is exactly >> > what hvc_console.c does. >> >> i have no idea what "hvc" is, but my limited knowledge was that it was >> for large powerpc servers, so i didnt bother looking at it too much. >> i simply wanted a way to create a tty on top of the hardware channel. >> if there is a framework that doesnt break this usage and lets me >> simplify my driver, then either works for me. > > HVC started out as the console for large powerpc, but has turned into > a generic framework for TTY drivers that are based on simple read/write > operations with or without interrupts. > > Please take a look at drivers/char/hvc_tile.c, which was added recently > for a scenario quite similar to yours (debug port, not irq). will do, thanks -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/