Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756452Ab0H3SEO (ORCPT ); Mon, 30 Aug 2010 14:04:14 -0400 Received: from smtp.outflux.net ([198.145.64.163]:36160 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756161Ab0H3SEM (ORCPT ); Mon, 30 Aug 2010 14:04:12 -0400 Date: Mon, 30 Aug 2010 11:03:03 -0700 From: Kees Cook To: Johannes Berg Cc: "John W. Linville" , linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Joe Perches , Tejun Heo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Jean Tourrilhes Subject: Re: [PATCH] wireless extensions: fix kernel heap content leak Message-ID: <20100830180302.GM4703@outflux.net> References: <20100827210240.GC4703@outflux.net> <20100827212254.GB32275@bougret.hpl.hp.com> <1283158058.3691.10.camel@jlt3.sipsolutions.net> <1283158704.3691.11.camel@jlt3.sipsolutions.net> <1283162341.3691.45.camel@jlt3.sipsolutions.net> <1283163894.3691.48.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1283163894.3691.48.camel@jlt3.sipsolutions.net> Organization: Canonical X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 30 Hi Johannes, On Mon, Aug 30, 2010 at 12:24:54PM +0200, Johannes Berg wrote: > --- wireless-testing.orig/net/wireless/wext-compat.c 2010-08-30 12:04:57.000000000 +0200 > +++ wireless-testing/net/wireless/wext-compat.c 2010-08-30 12:11:32.000000000 +0200 > @@ -1420,6 +1420,9 @@ int cfg80211_wext_giwessid(struct net_de > { > struct wireless_dev *wdev = dev->ieee80211_ptr; > > + data->flags = 0; > + data->length = 0; > + > switch (wdev->iftype) { > case NL80211_IFTYPE_ADHOC: > return cfg80211_ibss_wext_giwessid(dev, info, data, ssid); Thanks for all your work on this! Were you able to trigger the leak through cfg80211? If so, then this will need a CVE assigned and sent to stable too, I think. -Kees -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/