DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=IL+IlNRZ3KWB216VquUIznUG9o0GV/bUOR47wBYPlDqnZb08nu82EMuXUN7ua5iNJkY4LBXQBxzOKMLOHj42cYU1pOkDNZ1RhEwvxLkCqjLUwwGmjsWxDEQQDiZS3H4rG7v+deeOqXKrgTDcaFrA3KdOFFj29dt5sfyXXtGewzk=;
Message-ID: <373151.77032.qm@web180311.mail.gq1.yahoo.com>
Date: Mon, 30 Aug 2010 13:23:18 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH v4] gpio: Add driver for basic memory-mapped GPIO controllers
To: Andrew Morton <akpm@linux-foundation.org>,
        Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        David Brownell <dbrownell@users.sourceforge.net>,
        Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
In-Reply-To: <20100829212857.GA25592@oksana.dev.rtsoft.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 751
Lines: 24


--- On Sun, 8/29/10, Anton Vorontsov <cbouatmailru@gmail.com> wrote:
Brownell
> wrote:
> > But? do it without BUG()... 
> Yeah, good idea. Let's turn these BUG() into
> WARN_ON_ONCE()?

I'm not a big fan of redundant -- and
 noisy! error reports like
that:  recall that errors were already reported
(and ignored) on those paths, indicating invalid
GPIOs (requested, or direction set, etc).

The read paths should probably just return zero;
that's required in some cases, if you read the
interface spec.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/