Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756497Ab0HaA4z (ORCPT ); Mon, 30 Aug 2010 20:56:55 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:53237 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756477Ab0HaA4x (ORCPT ); Mon, 30 Aug 2010 20:56:53 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Minchan Kim Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system Cc: kosaki.motohiro@jp.fujitsu.com, Ying Han , Rik van Riel , Andrew Morton , linux-mm , LKML , Venkatesh Pallipadi , Johannes Weiner In-Reply-To: References: Message-Id: <20100831095542.87CA.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Tue, 31 Aug 2010 09:56:48 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 34 > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1b145e6..0b8a3ce 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1747,7 +1747,7 @@ static void shrink_zone(int priority, struct zone *zone, > * Even if we did not try to evict anon pages at all, we want to > * rebalance the anon lru active/inactive ratio. > */ > - if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0) > + if (nr_swap_pges > 0 && inactive_anon_is_low(zone, sc)) Sorry, I don't find any difference. What is your intention? > shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); > > throttle_vm_writeout(sc->gfp_mask); > > But Andrew merged middle version. > I will send this patch again. > > Thanks. > > -- > Kind regards, > Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/