Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756537Ab0HaBKU (ORCPT ); Mon, 30 Aug 2010 21:10:20 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:62911 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756284Ab0HaBKS convert rfc822-to-8bit (ORCPT ); Mon, 30 Aug 2010 21:10:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=kBryG0XSpJRMnD5ChYUjLIvFbO2hOIQKb7PSS+akGt+yxZjhq8Zwk5Au5NVWjLrnrV 2mmxk0WKfbBh4m/tkoju1lUbX1lK10ighPLzDUR7fEW0yMe+ORv6k6tlls92xnkrtJSC wlSBmX4j1q9TVaMPqfvD4vCEZjnMqnbz7OY3M= MIME-Version: 1.0 In-Reply-To: <20100831095542.87CA.A69D9226@jp.fujitsu.com> References: <20100831095542.87CA.A69D9226@jp.fujitsu.com> Date: Tue, 31 Aug 2010 10:10:17 +0900 Message-ID: Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system From: Minchan Kim To: KOSAKI Motohiro Cc: Ying Han , Rik van Riel , Andrew Morton , linux-mm , LKML , Venkatesh Pallipadi , Johannes Weiner Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 29 Hi, KOSAKI. On Tue, Aug 31, 2010 at 9:56 AM, KOSAKI Motohiro wrote: >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 1b145e6..0b8a3ce 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -1747,7 +1747,7 @@ static void shrink_zone(int priority, struct zone *zone, >> ? ? ? ? ?* Even if we did not try to evict anon pages at all, we want to >> ? ? ? ? ?* rebalance the anon lru active/inactive ratio. >> ? ? ? ? ?*/ >> - ? ? ? if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0) >> + ? ? ? if (nr_swap_pges > 0 && inactive_anon_is_low(zone, sc)) > > Sorry, I don't find any difference. What is your intention? > My intention is that smart gcc can compile out inactive_anon_is_low call in case of non swap configurable system. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/