Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756566Ab0HaBdJ (ORCPT ); Mon, 30 Aug 2010 21:33:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:36947 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756473Ab0HaBdI (ORCPT ); Mon, 30 Aug 2010 21:33:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.56,295,1280732400"; d="scan'208";a="833352408" Date: Tue, 31 Aug 2010 09:32:48 +0800 From: Wu Fengguang To: KOSAKI Motohiro Cc: Michael Rubin , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "jack@suse.cz" , "riel@redhat.com" , "akpm@linux-foundation.org" , "david@fromorbit.com" , "npiggin@kernel.dk" , "hch@lst.de" , "axboe@kernel.dk" Subject: Re: [PATCH 4/4] writeback: Reporting dirty thresholds in /proc/vmstat Message-ID: <20100831013248.GA8359@localhost> References: <20100830092446.524B.A69D9226@jp.fujitsu.com> <20100831095932.87CD.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100831095932.87CD.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1527 Lines: 32 On Tue, Aug 31, 2010 at 09:07:32AM +0800, KOSAKI Motohiro wrote: > > On Sun, Aug 29, 2010 at 5:28 PM, KOSAKI Motohiro > > wrote: > > > afaict, you and wu agreed /debug/bdi/default/stats is enough good. > > > why do you change your mention? > > > > I commented on this in the 0/4 email of the bug. I think these belong > > in /proc/vmstat but I saw they exist in /debug/bdi/default/stats. I > > figure they will probably not be accepted but I thought it was worth > > attaching for consideration of upgrading from debugfs to /proc. > > For reviewers view, we are reviewing your patch to merge immediately if all issue are fixed. > Then, I'm unhappy if you don't drop merge blocker item even though you merely want asking. > At least, you can make separate thread, no? > > Of cource, wen other user also want to expose via /proc interface, we are resume > this discusstion gradly. Michael asked promoting the dirty thresholds from debugfs to /proc. As a developer I'd interpret the question as: will there be enough applications/admins using it? If not, we'd better keep it as debugfs. Otherwise it benefits to do the interface promotion now, because it will hurt to accumulate many end user dependencies on debugfs over time.. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/