Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756593Ab0HaBpN (ORCPT ); Mon, 30 Aug 2010 21:45:13 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:37179 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756426Ab0HaBpM (ORCPT ); Mon, 30 Aug 2010 21:45:12 -0400 Message-ID: <001501cb48ae$262d8d60$66f8800a@maildom.okisemi.com> From: "Masayuki Ohtake" To: "Grant Likely" Cc: "Thomas Gleixner" , , "LKML" , "David Brownell" , , , , , , "Tomoya MORINAGA" , "David Woodhouse" , "Alan Cox" References: <4C77BD91.9070302@dsn.okisemi.com> <001401cb4814$fb4bdd70$66f8800a@maildom.okisemi.com> Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35 Date: Tue, 31 Aug 2010 10:45:07 +0900 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4300 Lines: 92 ----- Original Message ----- > From: "Grant Likely" > To: "Masayuki Ohtake" > Cc: "Thomas Gleixner" ; ; "LKML" ; "David Brownell" ; ; ; ; ; ; "Tomoya MORINAGA" ; "David Woodhouse" ; "Alan Cox" > Sent: Tuesday, August 31, 2010 3:23 AM > Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35 > > > On Mon, Aug 30, 2010 at 1:28 AM, Masayuki Ohtake > wrote: > > ----- Original Message ----- > > From: "Grant Likely" > > To: "Thomas Gleixner" > > Cc: "Masayuki Ohtak" ; ; "LKML" ; "David > > Brownell" ; ; ; > > ; ; ; "Tomoya MORINAGA" > > ; "David Woodhouse" ; "Alan Cox" > > Sent: Saturday, August 28, 2010 4:20 AM > > Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35 > > > > > >> On Fri, Aug 27, 2010 at 12:53 PM, Thomas Gleixner wrote: > >> > B1;2401;0cOn Fri, 27 Aug 2010, Grant Likely wrote: > >> >> [cc'ing Thomas Gleixner and David Woodhouse since this driver needs to > >> >> get some data about the platform (to know what spi_devices are > >> >> present) and I don't know how that is handled for x86 SoCs.] > >> > > >> > The best way to do all this platform specific configuration is to use > >> > device tree. I really don't want to have x86/mach-xyz/board[A-Z] > >> > horror, which is unavoidable when we don't get a sensible way to > >> > configure the boards. > >> > >> I knew you were going to say that! :-) > >> > >> Ohtak-san, for this patch I'd like you to drop the separate driver > >> that only registers the spi_devices and just submit the core driver. > > > > Sorry, I can't follow your discussion by lack of SPI knowledge. > > Which the above mean that "spi_register_board_info" moves to our spi_pch or > > delete for our driver ? > > I mean remove drivers/spi/spi_pch_device.c and the related Kconfig > bits from this patch. > The spi_device registration is a separate task > which should be submitted in a separate patch, and would be better > handled in either platform support code or with a device tree. How should we register spi_device information ? Could you show reference driver ? > > >> (You can of course keep the spi_device registration in your own tree > >> for debug purposes). I'll expect that the device will get > >> instantiated using a device tree to determine which spi_devices are > >> present. The parsing of spi device tree data will be moving into the > >> core spi subsystem code in the next merge window most likely, so it > >> can all be handled transparently. > >> > >> > SFI was meant to provide a lightweight ACPI, but > >> > now that device tree is generic and more platforms are using it, I > >> > really want to standartize on that and forget SFI. > >> > > >> > That makes even more sense, as all these AMBA peripherals which are > >> > duct-taped to a x86 core can be found in other SoCs with different > >> > cores as well. > >> > >> Indeed. BTW, Ohtak-san, is this spi bus device something brand new, > >> or is it derived from an existing spi device? > > > > Yes, Intel Topcliff is new concept device. > > As Thomas already commented, what I'm really interested in is whether > or not this spi controller is based on an older SPI controller. If it > is, then it may be possible to add support for this chip to an > existing driver instead of writing a whole new one. > Thanks, Ohtake(OKISemi) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/