Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754512Ab0HaGEf (ORCPT ); Tue, 31 Aug 2010 02:04:35 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:40569 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969Ab0HaGEe convert rfc822-to-8bit (ORCPT ); Tue, 31 Aug 2010 02:04:34 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=fvi6vq+ylnAEWHE1lJ249jXhM95HFBTzHo+DS41I5lFbBNR5QcDj6ZGkILe3DzlXUW s//+pr+UVpCM2eIubd0PThMgZ7EBiJ8ZVQt9Rn6gGpkusx4IIaPzlmEHrOPgsuZg268n yw6B7pKIw/tLiXNLOZngD7NJdnTiz5fQffIGk= MIME-Version: 1.0 In-Reply-To: References: <1282813649-8332-1-git-send-email-mark.brown314@gmail.com> <1282813649-8332-2-git-send-email-mark.brown314@gmail.com> From: Eric Miao Date: Tue, 31 Aug 2010 14:04:13 +0800 Message-ID: Subject: Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector To: "Mark F. Brown" Cc: Haojian Zhuang , linux-arm-kernel , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 43 On Tue, Aug 31, 2010 at 2:02 PM, Mark F. Brown wrote: > On Tue, Aug 31, 2010 at 1:48 AM, Eric Miao wrote: >> On Thu, Aug 26, 2010 at 5:07 PM, Mark F. Brown wrote: >>> Signed-off-by: Mark F. Brown >>> --- >>>  arch/arm/mach-mmp/include/mach/system.h |    2 +- >>>  1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/arch/arm/mach-mmp/include/mach/system.h b/arch/arm/mach-mmp/include/mach/system.h >>> index 4f5b0e0..926e9c0 100644 >>> --- a/arch/arm/mach-mmp/include/mach/system.h >>> +++ b/arch/arm/mach-mmp/include/mach/system.h >>> @@ -16,6 +16,6 @@ static inline void arch_idle(void) >>> >>>  static inline void arch_reset(char mode, const char *cmd) >>>  { >>> -       cpu_reset(0); >>> +       cpu_reset(0xffff0000); >> >> Not sure if this correct. But normally reset jump happens after we turn >> off the MMU and so on. Ain't the BootROM starts from 0 ? >> >>>  } >>>  #endif /* __ASM_MACH_SYSTEM_H */ >>> -- >>> 1.7.0.4 >>> >>> >> > > Eric, the boot-rom for pxa168 starts at 0xffff_0000. I am pretty sure > about that! If you set the reset vector to 0x0 it will crash during > reboot. I will send you xdb snapshots if you need me to. > OK, you are expert on this :-) Applied to 'fix'. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/