Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753986Ab0HaIpC (ORCPT ); Tue, 31 Aug 2010 04:45:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30159 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004Ab0HaIpA (ORCPT ); Tue, 31 Aug 2010 04:45:00 -0400 Message-ID: <4C7CC107.1050304@redhat.com> Date: Tue, 31 Aug 2010 10:44:55 +0200 From: Harald Hoyer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.4) Gecko/20100624 Fedora/3.1-1.fc14 Thunderbird/3.1 MIME-Version: 1.0 To: Eric Paris CC: Kay Sievers , linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, greg@kroah.com, sds@tycho.nsa.gov, dwalsh@redhat.com Subject: Re: selinux vs devtmpfs (vs udev) References: <1282950052.3284.110.camel@dhcp231-106.rdu.redhat.com> <1283210070.3284.139.camel@dhcp231-106.rdu.redhat.com> In-Reply-To: <1283210070.3284.139.camel@dhcp231-106.rdu.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2035 Lines: 50 On 08/31/2010 01:14 AM, Eric Paris wrote: > On Sat, 2010-08-28 at 11:57 +0200, Kay Sievers wrote: >> On Sat, Aug 28, 2010 at 01:00, Eric Paris wrote: > >>> In the new new days of devtmpfs things aren't as nice. The kernel is >>> magically creating files in /dev. These are getting created with the >>> 'default' SELinux context. So herein lies the problem. >>> >>> The first program that tries to access these files get denied by >>> SELinux. Now udev actually has logic in it to fix the label on any >>> closed device file, so udev will at that point swoop in, fix the label, >>> and the next program that tries to use the file will work just fine. Oh >>> fun! > >> Udev should still label all device nodes, even when they are created >> by the kernel. Devtmpfs or not should not make a difference here. >> >> I guess it's a udev bug introduced with: >> http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=578cc8a8085a47c963b5940459e475ac5f07219c >> >> and we just need to fix that. > > Looks like the likely cause. I see a note in one of the bugzillas that > says: > > Aug 30 14:03:09 pippin udevd-work[347]: preserve file '/dev/dri/card0', > because it has correct dev_t > > Which is certainly the part of code in question. Do you have a quick > fix in mind that you plan to push upstream or should I ask the RH udev > guy to come up with something? > > -Eric > The RH udev guy says: This patch was introduced, because Red Hat engineers requested, that the selinux context should not be modified, after they set their own custom context (virtual machine management). So, either we differentiate between "add" and "change" events, or we should check against the "kernel default" selinux context, before we call udev_selinux_lsetfilecon(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/