Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757411Ab0HaNwb (ORCPT ); Tue, 31 Aug 2010 09:52:31 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:34048 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757388Ab0HaNw3 (ORCPT ); Tue, 31 Aug 2010 09:52:29 -0400 Date: Tue, 31 Aug 2010 09:52:26 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Clemens Ladisch cc: Simon Arlott , Greg KH , Linux Kernel Mailing List , USB list Subject: Re: [PATCH] USB: output an error message when the pipe type doesn't match the endpoint type In-Reply-To: <4C7CA411.5070601@ladisch.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 22 On Tue, 31 Aug 2010, Clemens Ladisch wrote: > Simon Arlott wrote: > > Commit f661c6f8c67bd55e93348f160d590ff9edf08904 adds a check of the pipe type if > > CONFIG_USB_DEBUG is enabled, > > I didn't see that commit last year, but wouldn't it break devices like > the ESI MIDI Mate whose descriptors want to have low-speed bulk transfers > and where the driver has to submit interrupt transfers instead to get it > to work at all? When the kernel sees those invalid low-speed bulk endpoint descriptors, it changes its internal copy of the descriptor to interrupt. Hence when the driver submits interrupt URBs, they work correctly. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/